Dan Kenigsberg has posted comments on this change. Change subject: BZ#832227: vdsm-reg.conf: change vdc_host_port ......................................................................
Patch Set 8: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm_reg/engine.py.in Line 77: return compatPort[portNumber][0], \ this is equivalent to return compatPort[portNumber] which would explode if the user used a non-standard port number. how about return compatPort.get(portNumber, (None, False)) ? -- To view, visit http://gerrit.ovirt.org/5367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb36d1ca0614741d24b512572f101f848b24e6d3 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Joey Boggs <[email protected]> Gerrit-Reviewer: Michael Burns <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
