Dan Kenigsberg has posted comments on this change. Change subject: BZ#832227: vdsm-reg.conf: change vdc_host_port ......................................................................
Patch Set 9: Looks good to me, approved (2 inline comments) I cannot say that I love the, code... .................................................... File vdsm_reg/engine.py.in Line 60: Until the version 3.0, oVirt Engine provided port 8443/8080 to oVirt Node docstrings should be put *within* the function, not before it. Line 238: if not isHostReachable(host=self.engine_server.value(), this area of the code is still too complex. I will trust you that it is functionally fine -- To view, visit http://gerrit.ovirt.org/5367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb36d1ca0614741d24b512572f101f848b24e6d3 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Joey Boggs <[email protected]> Gerrit-Reviewer: Michael Burns <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
