Mark Wu has posted comments on this change. Change subject: Basic tests for the tc module ......................................................................
Patch Set 11: Verified; I would prefer that you didn't submit this After installing package kernel-modules-extra and running 'modprobe sch_ingress', I can run the test successfully. I suggest to load sch_ingress explicitly in the test case and skip the test with a warning message to install "kernel-modules-extra" on loading failure. Otherwise, the failure of this test case could block building, which is bad for developer. And is it necessarily to add a requires of kernel-modules-extra for vdsm-tests on fedora ? -- To view, visit http://gerrit.ovirt.org/6225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee9437d1b5a96b3896df157f13888485ae7292d2 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roman Fenkhuber <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Roman Fenkhuber <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
