Roman Fenkhuber has posted comments on this change. Change subject: Basic tests for the tc module ......................................................................
Patch Set 11: I think testing for the three or four modules in the testcase is the wrong place for two reasons: - my test does not depend on these modules, it is the tc module itself. - testing for modules directly can lead to false positive, as a custom kernel could have built in the functionality. Isn't it better to run a script like brctl addbr lala tc qdisk add dev lala ingress by autotools which would tell you that the tc modules are a direct dependency? -- To view, visit http://gerrit.ovirt.org/6225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee9437d1b5a96b3896df157f13888485ae7292d2 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roman Fenkhuber <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Roman Fenkhuber <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
