Dan Kenigsberg has posted comments on this change.
Change subject: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File vdsm/storage/storageServer.py
Line 252: options = ("".join(config.get('irs',
'nfs_mount_options').split())).split(",")
long line
Line 253: self._log.warning("Using deprecated nfs_mount_options
parameter "
a thought: instead of this long story in the log, report this fact as a new
'alert' for this storage domain.
See StoragePool.getInfo(). it may be a pain to implement, though.
Line 262: parts = opt.split("=")
this assumes that all nfs options look like key=value. `man nfs` claims this is
not the case.
Line 278: self._timeout = opts['timeo'];
*semicolon*!? are we C?
--
To view, visit http://gerrit.ovirt.org/5368
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1d13bfd98a9b41b9728bdcb7f01b3161c26bd8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
