Greg Padgett has posted comments on this change.
Change subject: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf
......................................................................
Patch Set 5: (4 inline comments)
Dan, thanks. I uploaded patch set 6, which addresses some of the issues. I'll
mark it -1 as a WIP while looking into a storage domain alert.
....................................................
File vdsm/storage/storageServer.py
Line 252: options = ("".join(config.get('irs',
'nfs_mount_options').split())).split(",")
Done
Line 253: self._log.warning("Using deprecated nfs_mount_options
parameter "
Thanks for the idea, I am looking into it.
Line 262: parts = opt.split("=")
True, even the default options of "soft,nosharecache" do not follow the
key=value convention. However IIUC, Python's str.split() will happy return a
one-element list if it splits a string that contains no separator. (AFAICT,
The documentation is silent on this particular point, but it is corroborated by
the legality of maxsplit=0.)
Line 278: self._timeout = opts['timeo'];
Yes, that reflex makes for some gross Python code, my apologies. Fixed all 5
places.
--
To view, visit http://gerrit.ovirt.org/5368
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1d13bfd98a9b41b9728bdcb7f01b3161c26bd8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
