Dan Kenigsberg has posted comments on this change. Change subject: join supervdsm subprocess after terminated to avoid defunct status ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) saggi, could you take a look? .................................................... File vdsm/supervdsmServer.py Line 188: proc.join() I'm a bit worried about the child getting hung on a lost nfs mount. this line would make the parent block as well. -- To view, visit http://gerrit.ovirt.org/6503 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cdcfb3b467e9226f14a4ebc2845ff2db0f19b5f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
