Xu He Jie has posted comments on this change.
Change subject: join supervdsm subprocess after terminated to avoid defunct
status
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/supervdsmServer.py
Line 184:
Line 185: res, err = pipe.recv()
Line 186: pipe.send("Bye")
Line 187: proc.terminate()
Line 188: proc.join()
or ignore SIGCHLD? ignore this signal there won't produce any zombie process
Line 189: if err is not None:
Line 190: raise err
Line 191:
Line 192: return res
--
To view, visit http://gerrit.ovirt.org/6503
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0cdcfb3b467e9226f14a4ebc2845ff2db0f19b5f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
