Shu Ming has posted comments on this change. Change subject: Add deathSignal options to better peopen ......................................................................
Patch Set 6: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/betterPopen/createprocess.c Line 260: errno = prctl(PR_SET_PDEATHSIG, deathSignal); errno is actually a reserved variable in C library. It should not set by the application. Usually, in linux C library, if the return value of prtcl is negative which means some errors hapen, errno can be checked to know which kind of error occurs. Line 262: // setting the death signal "//" is not C-native. "/*" and "*/" should be used for standard C comments. I prefer this format: /* Check that parent did not already die between fork and us setting the death signal */ -- To view, visit http://gerrit.ovirt.org/6241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
