Dan Kenigsberg has posted comments on this change. Change subject: cleanup: do not use external program ipcalc for ip validation ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) Thanks, Alon. I think you should clean configure.ac, too. .................................................... File vdsm/configNetwork.py Line 469: ret = False ret is unused Line 477: except: we use except with no qualifications quite often, but it is quite evil. I suppose you care only for the ValueError of int(). If so, please limit the catch-all expcet, and the size of the try block. -- To view, visit http://gerrit.ovirt.org/6929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7d5a6515591147cfc86c9279f69da44f94a9872 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
