Dan Kenigsberg has submitted this change and it was merged. Change subject: cleanup: do not use external program ipcalc for ip validation ......................................................................
cleanup: do not use external program ipcalc for ip validation IPv4 addresses are simple to parse and validate. No need to execute external process for the task. Especially if process is not supported by all platforms, and it has no added value. $ ipcalc -c -4 0.0.0.0 && echo ok ok $ ipcalc -c -4 255.255.255.255 && echo ok ok $ ipcalc -c -m -4 1.1.1.1 && echo ok ok Change-Id: Ia7d5a6515591147cfc86c9279f69da44f94a9872 Signed-off-by: Alon Bar-Lev <[email protected]> --- M configure.ac M vdsm/configNetwork.py M vdsm/constants.py.in 3 files changed, 15 insertions(+), 17 deletions(-) Approvals: Alon Bar-Lev: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7d5a6515591147cfc86c9279f69da44f94a9872 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
