Zhou Zheng Sheng has posted comments on this change. Change subject: call sync before umount in mkFloppyFs ......................................................................
Patch Set 1: This problem causes unit test "test_mkFloppyFs" in "tests/mkimageTests.py" fail. My uname -a is as follow, Linux zhshzhouf17 3.5.0-2.fc17.x86_64 #1 SMP Mon Jul 30 14:48:59 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux On my system if I umount immediately after wrting file contents, umount will fail. To reproduce the problem, you can use the script below. The script mimics what mkFloppyFs does. #!/usr/bin/bash mkdir tmpMount /usr/sbin/mkfs.msdos -C floppy.img 1440 /usr/bin/mount -o loop floppy.img tmpMount echo '123'>tmpMount/tst1.txt echo '123'>tmpMount/tst2.txt echo '123'>tmpMount/tst3.txt echo '123'>tmpMount/tst4.txt echo '123'>tmpMount/tst5.txt echo '123'>tmpMount/tst6.txt echo '123'>tmpMount/tst7.txt echo '123'>tmpMount/tst8.txt echo '123'>tmpMount/tst9.txt #sleep 2 /usr/bin/umount -f tmpMount rm -rf tmpMount floppy.img When I run the script, umount fails. On some other machine of VM, the script may not fail. If I uncomment the "sleep" command in the script, umount works again. This means some data need to be sync to disk, so the device is busy, and umount can not detach the devices. On my system, if I sync before umount, umount will work. Some of my colleagues run into this problem as well. The patch run through autobuild.sh -- To view, visit http://gerrit.ovirt.org/6995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
