Dan Kenigsberg has posted comments on this change. Change subject: call sync before umount in mkFloppyFs ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) thanks, but I'd like to understand the issue a bit better. .................................................... File vdsm/mkimage.py Line 87: # otherwise umount raises "device busy" exception on some machines could you understand why is the device busy? what is holding it? could you call `lsof` just before umount to catch them? maybe we should have closed f explicitly in _decodeFilesIntoDir? -- To view, visit http://gerrit.ovirt.org/6995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: ShaoHe Feng <shao...@linux.vnet.ibm.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
