Deepak C Shetty has posted comments on this change. Change subject: [RFC] Support for GLUSTERFS_DOMAIN ......................................................................
Patch Set 1: (8 inline comments) I have posted v2. Pls provide your review comments. .................................................... File vdsm/libvirtvm.py Line 88: self._vm._dom.blockInfo(vmDrive.path, 0) Done Line 991: # Determine if its network type Done Line 1000: def blockDev(self): Done Line 1003: self._blockDev = utils.isBlockDevice(self.path['path']) Done Line 1521: if drv.path == diskParams['path']: Done Line 1875: mergeStatus['path'] = mergeDrive.path Done Line 1993: capacity, alloc, physical = self._dom.blockInfo(d.path, 0) Done. For all the .path changes, I avoided them, by defining new key in drive dict by name 'vmVolInfo'. Posted v2 with the same. .................................................... File vdsm/storage/volume.py Line 294: clsName, "shareVolumeRollback", [dstPath])) Do you mean this change is unrelated to the patch. Yes, but i did it for pep8 compliance -- To view, visit http://gerrit.ovirt.org/6856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty <deepa...@linux.vnet.ibm.com> Gerrit-Reviewer: Deepak C Shetty <deepa...@linux.vnet.ibm.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
