Deepak C Shetty has posted comments on this change. Change subject: [RFC] Support for GLUSTERFS_DOMAIN ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/storage/glusterVolume.py Line 39: 'protocol': 'gluster', 'volPort': opt_volport, Line 40: 'volTransport': opt_voltrans, Line 41: 'volfileServer': volfileServer} Line 42: Line 43: return vmVolInfo I think its the same, does it really matter ? i feel what I have done is more legible :) -- To view, visit http://gerrit.ovirt.org/6856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
