Piotr Kliczewski has posted comments on this change. Change subject: ssl: m2crypto removal ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/39990/4/vdsm/clientIF.py File vdsm/clientIF.py: Line 177: if config.getboolean('vars', 'ssl'): Line 178: truststore_path = config.get('vars', 'trust_store_path') Line 179: protocol = ( Line 180: ssl.PROTOCOL_TLSv1 Line 181: if config.get('vars', 'ssl_protocol') == 'sslv23' > this is particularly confusing. We are to use tlsv1, but ONLY when the user We use tlsv1 by default or sslv23 when we asked by used. Default value in config.py is still sslv23. It is exactly the same behavior as we had before this change. Line 182: else ssl.PROTOCOL_SSLv23 Line 183: ) Line 184: sslinfo = SSLInfo( Line 185: key_file=os.path.join(truststore_path, 'keys', 'vdsmkey.pem'), -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
