Juan Hernandez has posted comments on this change. Change subject: ssl: m2crypto removal ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/39990/3/tests/sslTests.py File tests/sslTests.py: Line 369: "-key", self.keyfile, Line 370: ]) Line 371: self.assertEquals(rc, 0) Line 372: Line 373: @brokentest This is the test that checks that sessions are cached, in order to avoid performance issues. If it is broken then it should be fixed, and should pass. If the code can't pass this check then this change shouldn't be merged. Line 374: def testSessionIsCached(self): Line 375: """ Line 376: Verify that SSL the session identifier is preserved when Line 377: connecting two times without stopping the server. -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
