Nir Soffer has posted comments on this change. Change subject: ceph: Support ephemeral Libvirt secrets ......................................................................
Patch Set 11: (3 comments) https://gerrit.ovirt.org/#/c/40712/11/vdsm/virt/secret.py File vdsm/virt/secret.py: Line 27: Line 28: from . import vmxml Line 29: Line 30: Line 31: def register(secrets): set() Line 32: try: Line 33: secrets = [Secret(params) for params in secrets] Line 34: except ValueError as e: Line 35: logging.warning("Attempt to register invalid secret: %s", e) Line 33: secrets = [Secret(params) for params in secrets] Line 34: except ValueError as e: Line 35: logging.warning("Attempt to register invalid secret: %s", e) Line 36: return response.error("secretBadRequestErr") Line 37: clear old secrets Line 38: try: Line 39: con = libvirtconnection.get() Line 40: for secret in secrets: Line 41: logging.info("Registering secret %s", secret) Line 46: Line 47: return response.success() Line 48: Line 49: Line 50: def unregister(uuids): clear() Line 51: try: Line 52: uuids = [str(uuid.UUID(s)) for s in uuids] Line 53: except ValueError as e: Line 54: logging.warning("Attempt to unregister invalid uuid %s: %s" % -- To view, visit https://gerrit.ovirt.org/40712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
