Nir Soffer has posted comments on this change. Change subject: ceph: Support ephemeral Libvirt secrets ......................................................................
Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/40712/13/vdsm/virt/secret.py File vdsm/virt/secret.py: Line 89: self.description = params.get("description") Line 90: Line 91: def register(self, con): Line 92: virsecret = con.secretDefineXML(self.toxml()) Line 93: virsecret.setValue(self.password) > 'setValue' expects c_ubyte (according to c api [*]). Since the function enc did you check that setValue with base64 encoded paasword cause authentication to fail? Line 94: Line 95: def toxml(self): Line 96: secret = vmxml.Element('secret', ephemeral="yes", private="yes") Line 97: if self.description: -- To view, visit https://gerrit.ovirt.org/40712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
