Dan Kenigsberg has posted comments on this change. Change subject: virt: bind console to unix domain socket ......................................................................
Patch Set 3: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/40704/3//COMMIT_MSG Commit Message: Line 13: VDSM needs to bind the guest console to Line 14: an unix domain socket, to make possible Line 15: for the ovirt-vmconsole package to reach it. Line 16: Line 17: Caveat Emptor: please state clearly that Vdsm does not do that (at the moment?) Line 18: The unix domain socket directory must have the following Line 19: permissions, ownership and SELinux permissions: Line 20: Line 21: /var/run/ovirt-vmconsole-console/ https://gerrit.ovirt.org/#/c/40704/3/vdsm/virt/vmdevices/core.py File vdsm/virt/vmdevices/core.py: Line 92: Line 93: def prepare(self): Line 94: try: Line 95: supervdsm.getProxy().prepareVmChannel(self._path) Line 96: except Exception: let us explode if this has failed. Line 97: self.log.exception( Line 98: "Failed to prepare the VM console channel") Line 99: Line 100: def cleanup(self): -- To view, visit https://gerrit.ovirt.org/40704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a876cd7f3b848aa9dde8123d459dc292729b303 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
