Francesco Romani has posted comments on this change. Change subject: virt: bind console to unix domain socket ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40704/3/vdsm/virt/vmdevices/core.py File vdsm/virt/vmdevices/core.py: Line 112: Line 113: or Line 114: Line 115: <console type='unix'> Line 116: <source mode='bind' path='/var/run/ovirt-vmconsole-console'> lacks the ${vmId}.sock part Line 117: <target type='virtio' port='0'/> Line 118: </console> Line 119: """ Line 120: if utils.tobool(self.specParams.get('enableSocket', False)): -- To view, visit https://gerrit.ovirt.org/40704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a876cd7f3b848aa9dde8123d459dc292729b303 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
