Nir Soffer has posted comments on this change. Change subject: ceph: Support ephemeral Libvirt secrets ......................................................................
Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/40712/14/tests/vmSecretTests.py File tests/vmSecretTests.py: Line 226: def test_unregister_missing(self): Line 227: existing_sec = make_secret() Line 228: secret.register([existing_sec]) Line 229: missing_sec = make_secret() Line 230: res = secret.unregister([missing_sec["uuid"], existing_sec["uuid"]]) > pep8: line too long... You mean line 192 - fixed in version 15 Line 231: self.assertEqual(res, response.success()) Line 232: self.assertEqual({}, self.connection.secrets) Line 233: Line 234: def test_unregister_libvirt_error(self): -- To view, visit https://gerrit.ovirt.org/40712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
