Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: Add register verb ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/40966/5/lib/vdsm/tool/register.py File lib/vdsm/tool/register.py: Line 51: from Engine Line 52: ssh_port - Port of ssh daemon is running Line 53: check_fqdn - Validate Engine FQDN against CA (True or False) Line 54: Default is TRUE Line 55: vdc_port - The communication port between VDSM and Engine this is a very vague documentation for a very odd name. isn't it simply the port that Vdsm is listening on? Line 56: node_fqdn - Specify node FQDN Line 57: node_name - Specify node name Line 58: """ Line 59: self.logger = self._set_logger() -- To view, visit https://gerrit.ovirt.org/40966 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica800027beec1e5a20165bb5e1e78baf9283c1da Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
