Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-tool: Add register verb ......................................................................
Patch Set 6: Verified+1 (1 comment) https://gerrit.ovirt.org/#/c/40966/6/lib/vdsm/tool/register.py File lib/vdsm/tool/register.py: Line 417: Line 418: # Needed by vdsm-tool. Otherwise it complains about register Line 419: # option doesn't exist Line 420: parser.add_argument( Line 421: 'register', Hi Yaniv, without this line, I see the line below, is that expected to add the register as argument or Am I missing something? Suggestion? # vdsm-tool register --engine-fqdn 192.168.122.166 --check-fqdn False usage: vdsm-tool [-h] [--node-fqdn NODE_FQDN] [--node-name NODE_NAME] --engine-fqdn ENGINE_FQDN [--engine-https-port ENGINE_HTTPS_PORT] [--ssh-user SSH_USER] [--ssh-port SSH_PORT] [--check-fqdn CHECK_FQDN] [--fingerprint FINGERPRINT] [--vdsm-port VDSM_PORT] vdsm-tool: error: unrecognized arguments: register Thanks! Line 422: ) Line 423: Line 424: parser.add_argument( Line 425: '--node-fqdn', -- To view, visit https://gerrit.ovirt.org/40966 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica800027beec1e5a20165bb5e1e78baf9283c1da Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
