Dan Kenigsberg has posted comments on this change. Change subject: Replacing minidom with ElementTree in caps.py ......................................................................
Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/41078/3/tests/capsTests.py File tests/capsTests.py: Line 238: capsData) Line 239: self.assertTrue(result) Line 240: Line 241: def testGetAllCpuModels(self): Line 242: fileName = 'cpu_map.xml' it seems that you need to rebase this patch on the most-recent version of your https://gerrit.ovirt.org/#/c/41077/ Line 243: result = caps._getAllCpuModels(capfile=fileName, Line 244: arch='x86') Line 245: Line 246: expected = {'qemu32': None, 'Haswell': 'Intel', 'cpu64-rhel6': None, https://gerrit.ovirt.org/#/c/41078/3/vdsm/caps.py File vdsm/caps.py: Line 425: list I don't suppose that the list() call is required Line 438: vendor = allModels.get(elementName, None) This line is not expected to raise a StopIteration, and as such, it should sit outside the try-clause. the "else" clause is more fitting. -- To view, visit https://gerrit.ovirt.org/41078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c1ca58807515922347e2255c77b4f950decd619 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
