Dan Kenigsberg has posted comments on this change. Change subject: Replacing minidom with ElementTree in caps.py ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/41078/5/vdsm/caps.py File vdsm/caps.py: Line 304: caps = ET.fromstring(capabilities) Line 305: host = caps.iter(tag='host').next() Line 306: cells = host.iter(tag='cells').next() Line 307: cellsInfo = {} Line 308: cellSets = cells.findall('cell') please notice Vinzenz question: why did you use findall() here, but iter() elsewhere? Line 309: for cell in cellSets: Line 310: cellInfo = {} Line 311: cpus = [] Line 312: for cpu in cell.iter(tag='cpu'): -- To view, visit https://gerrit.ovirt.org/41078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c1ca58807515922347e2255c77b4f950decd619 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
