Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-tool: Add register verb ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/40966/10/lib/vdsm/tool/register.py File lib/vdsm/tool/register.py: Line 70: Line 71: if engine_https_port is None: Line 72: self.engine_port = "443" Line 73: else: Line 74: self.engine_port = engine_https_port missing: self.engine_url = "https://{e}:{p}"; e=engine.fqdn, p=engine.port.. Line 75: self.logger.debug("Engine https port: {hp}".format( Line 76: hp=self.engine_port)) Line 77: Line 78: if check_fqdn is None: -- To view, visit https://gerrit.ovirt.org/40966 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica800027beec1e5a20165bb5e1e78baf9283c1da Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
