Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: Add register verb ......................................................................
Patch Set 8: Code-Review-1 (1 comment) minor nit. please check for more dead code. Please state how this was verified. Did you try a negative flow (missing Engine)? https://gerrit.ovirt.org/#/c/40966/8/lib/vdsm/tool/register.py File lib/vdsm/tool/register.py: Line 386: self._execute_http_request(self.url_reg) Line 387: self.logger.info("Registration completed, host is pending approval" Line 388: " on Engine: {e}".format(e=self.engine_fqdn)) Line 389: Line 390: def get_fingerprint(self): this function is unused Line 391: """ Line 392: Return the fingerprint for validation Line 393: """ Line 394: return self.fprint -- To view, visit https://gerrit.ovirt.org/40966 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica800027beec1e5a20165bb5e1e78baf9283c1da Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
