Michal Skrivanek has posted comments on this change. Change subject: migration: Support SPICE seamless migration over NAT ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/41223/1/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 347: # TODO: use libvirt constants when bz#1222795 is fixed Line 348: params = {VIR_MIGRATE_PARAM_URI: str(muri), Line 349: VIR_MIGRATE_PARAM_BANDWIDTH: maxBandwidth} Line 350: if self._consoleAddress: Line 351: params[VIR_MIGRATE_PARAM_GRAPHICS_URI] = \ > libvirt calls this graphicsURI. Can we follow suit? what's wrong with the name? Seems ok to me +1 for vdsClient Line 352: str(self._consoleAddress) Line 353: Line 354: flags = (libvirt.VIR_MIGRATE_LIVE | Line 355: libvirt.VIR_MIGRATE_PEER2PEER | -- To view, visit https://gerrit.ovirt.org/41223 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2b765c62aaf1cc694990205b518558e808516 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
