Yeela Kaplan has posted comments on this change. Change subject: migration: Support SPICE seamless migration over NAT ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/41223/4/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 348: # TODO: use libvirt constants when bz#1222795 is fixed Line 349: params = {VIR_MIGRATE_PARAM_URI: str(muri), Line 350: VIR_MIGRATE_PARAM_BANDWIDTH: maxBandwidth} Line 351: if self._consoleAddress: Line 352: if self._vm.hasSpice: > I think this is the best we can do Do we have a way of knowing about this? Line 353: graphics = 'spice' Line 354: else: Line 355: graphics = 'vnc' Line 356: params[VIR_MIGRATE_PARAM_GRAPHICS_URI] = \ Line 353: graphics = 'spice' Line 354: else: Line 355: graphics = 'vnc' Line 356: params[VIR_MIGRATE_PARAM_GRAPHICS_URI] = \ Line 357: str('%s://%s' % (graphics, self._consoleAddress)) > minor nit: no need for both continuation ('\') and str(), you can write removed the '\', but for str - libvirt does not recognize it without the conversion. Line 358: Line 359: flags = (libvirt.VIR_MIGRATE_LIVE | Line 360: libvirt.VIR_MIGRATE_PEER2PEER | Line 361: (libvirt.VIR_MIGRATE_TUNNELLED if -- To view, visit https://gerrit.ovirt.org/41223 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2b765c62aaf1cc694990205b518558e808516 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
