Timothy Asir has posted comments on this change. Change subject: gluster:fix NoneType error for some devices does not contain sysfsPath ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/41262/1/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 81: info['uuid'] = device.format.uuid or '' Line 82: if hasattr(udev, 'get_device'): Line 83: dev = udev.get_device(device.sysfsPath) or {} Line 84: elif hasattr(udev, 'udev_get_device'): Line 85: dev = udev.udev_get_device(device.sysfsPath) or {} > You need to find out why None is returned. Its a bug in blivet. Which does not assign sysfsPath for the vg devices. However if there is any thin pool created from the vg. It assigns the sysfsPath to its thin pool. Line 86: else: Line 87: dev = {} Line 88: info['fsType'] = device.format.type or dev.get('ID_FS_TYPE', '') Line 89: if hasattr(device.format, 'mountpoint'): -- To view, visit https://gerrit.ovirt.org/41262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
