Yaniv Bronhaim has posted comments on this change. Change subject: stomp: server side subscriptions ......................................................................
Patch Set 28: (2 comments) https://gerrit.ovirt.org/#/c/38451/28/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 27: Line 28: _STATE_LEN = "Waiting for message length" Line 29: _STATE_MSG = "Waiting for message" Line 30: Line 31: why did you change filename? Line 32: _DEFAULT_RESPONSE_DESTINATIOM = "/queue/_local/vdsm/reponses" Line 33: _DEFAULT_REQUEST_DESTINATION = "/queue/_local/vdsm/requests" Line 34: Line 35: _FAKE_SUB_ID = "__vdsm_fake_broker__" Line 168: self._handle_internal(dispatcher, stomp.LEGACY_SUB_ID_RES, Line 169: frame.body) Line 170: return Line 171: Line 172: subs = self._sub_dests[destination] what about KeyError here? and why isn't it under else scope instead of those "return"s Line 173: if not subs: Line 174: self._send_error("Subscription not available", Line 175: dispatcher.connection) Line 176: return -- To view, visit https://gerrit.ovirt.org/38451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
