Piotr Kliczewski has posted comments on this change.

Change subject: stomp: server side subscriptions
......................................................................


Patch Set 28:

(1 comment)

https://gerrit.ovirt.org/#/c/38451/28/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:

Line 20: 
Line 21: from vdsm.utils import monotonic_time
Line 22: import re
Line 23: 
Line 24: # REQUIRED_FOR: engine-3.5
> yes i know.. i would just add that it safe to remove it when engine-3.5 is 
Done
Line 25: LEGACY_SUB_ID_REQ = "/queue/_local/vdsm/requests"
Line 26: LEGACY_SUB_ID_RES = "/queue/_local/vdsm/reponses"
Line 27: 
Line 28: _RE_ESCAPE_SEQUENCE = re.compile(r"\\(.)")


-- 
To view, visit https://gerrit.ovirt.org/38451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to