Michal Skrivanek has posted comments on this change.

Change subject: serial console: add code to prepare the path
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/41896/3/vdsm/vdsm
File vdsm/vdsm:

Line 90: utils.panic("Error initializing IRS")
how about using this for bailing out from vmconsoledir issue?

It may sound a bit harsh, OTOH if you don't touch it it should keep working, 
And if you screwed it then we should scream loud


-- 
To view, visit https://gerrit.ovirt.org/41896
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f851d7f7233265d33896b3aad5604e84c8af53b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to