Nir Soffer has posted comments on this change. Change subject: multipath: Fix "HITACHI"/"DF.* configuration ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/41243/4//COMMIT_MSG Commit Message: Line 9: The multipath configuration we ship is missing important settings Line 10: embedded in multiapth daemon. Overriding these defaults is needed to Line 11: enable vdsm required configuration, but also remove any option we don't Line 12: mention in our mulitpath device configuration, causing possible Line 13: reliability or performance issues. > Can you please explain... The purpuse of our multipath configuration is to add the vdsm required options: features "0" no_path_retry fail We like to use other settings which are compiled into multipathd. Howeve, multipathd does not support inheritance - if you define an empty section, you do not inherit the options from the builtin settings. You simply get some compiled global default, instead of the device specific value. The only way to achieve this in current multipath version is to copy the defaults from multipath source, and add our defaults, and add a device section with all the settings. This is exactly what we did for Vnx devices (DGC/.*). See https://gerrit.ovirt.org/35072 I copied the defaults from multipath.conf.defaults, which is part of multipath source. If multipath will change the defualts, we will not use them, since we are overriding them. This is true for both old configuration (empty section) and new (non-empty section). Upstream multipath support a new "overrides" section - we will be able to define global "no_path_retry fail" override and inherit the builtin options for all devices, dropping the current configuration. Line 14: Line 15: The new configuration was copied from upstream multiapth-tools settings, Line 16: updated on 2013-07-16, and override the "features" and "no_path_retry" Line 17: settings required by vdsm. Line 12: mention in our mulitpath device configuration, causing possible Line 13: reliability or performance issues. Line 14: Line 15: The new configuration was copied from upstream multiapth-tools settings, Line 16: updated on 2013-07-16, and override the "features" and "no_path_retry" > Consider adding the upstream commit hash and/or link to gitweb OK Line 17: settings required by vdsm. Line 18: Line 19: Requires testing with the relevant storage server. Line 20: -- To view, visit https://gerrit.ovirt.org/41243 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78195b148aa3953f56b5a0b97366ccbdb3030d00 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
