Nir Soffer has posted comments on this change.

Change subject: multipath: Fix "HITACHI"/"DF.* configuration
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/41243/5/lib/vdsm/tool/configurators/multipath.py
File lib/vdsm/tool/configurators/multipath.py:

Line 58:         hardware_handler        "0"
Line 59:         prio                    "hds"
Line 60:         failback                "immediate"
Line 61:         rr_weight               "uniform"
Line 62:         # vdsm required configuration
> /s/required/custom
Whats wrong with "required"? This is describe the semantics of these options - 
we require them.

This is also used in the existing configuration (see DGC/.*)
Line 63:         features                "0"
Line 64:         no_path_retry           fail
Line 65:     }
Line 66:     device {


-- 
To view, visit https://gerrit.ovirt.org/41243
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78195b148aa3953f56b5a0b97366ccbdb3030d00
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Ala Hino <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to