Francesco Romani has posted comments on this change. Change subject: ceph: Add option to clear other secrets ......................................................................
Patch Set 15: +1 for the concept. From the perspective of the API, I'm not sure coalescing the clear in the register verb is clean enough. Why don't just let Engine explicitely clear the secrets using a separate verb? Engine knows already it should do that, because it has to raise the clear=True flag in register() call. -- To view, visit https://gerrit.ovirt.org/40853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I476e5aa0bd4a48d1837de09c59597f180fa38823 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
