Nir Soffer has posted comments on this change. Change subject: ceph: Add option to clear other secrets ......................................................................
Patch Set 15: Francesco, I agree the the clear flag is not pretty, but do you think we need a third api just to clear all secrets? The required verbs are: - registerSecrets - add list of secrets - unregisterSecerts - remove list of secrets These options are enough for the positive flows. However in some negative flows, engines does not know which secrets are on a machine, and adding an easy way to remove all secrets would make it much easier for our friends on the engine side. If we want a third api, I would add: - setSecrets - Set given secrets and clear other We could have only this api and require that engine will send always all secrets. This is what we do adding and removing storage domains, engine send connectStoragePool with a map of the current domains. But Daniel wanted an easy way to add or remove the secrets associated with a storage domain when we add or remove it, instead of looking up all secrets associated with all domains. So If we want a nicer api, I suggest this: - addSecrets(secrets) - removeSecrets(uuids) - setSecrets(secrets) Use cases: - Activating a domain - addSecrets(domainSecrets) - Deactivating a domain - removeSecrets(domainSecrets) - Deactivating host - setSecrets([]) - Activating a host - setSecrets(allDomainsSecrets) - Reconnecting to host - setSecrets(allDomainsSecrets) What do you think? -- To view, visit https://gerrit.ovirt.org/40853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I476e5aa0bd4a48d1837de09c59597f180fa38823 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
