Piotr Kliczewski has posted comments on this change. Change subject: ssl: m2crypto removal ......................................................................
Patch Set 9: (1 comment) There were following steps performed when testing this patch: "Performed standard RHEV-M REST API load test with 100 VMs and 100 concurrent threads." The tests where performed for engine 3.5 both xmlrpc and jsonrpc and 3.4 with xmlrpc. There was no significant difference with and without this patch. vdsm-on-el7 was only on tech-preview in 3.4. So we actually do not care about how vdsm-of-3.6 behaves with engine-3.3. https://gerrit.ovirt.org/#/c/39990/9/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 17: import stomp Line 18: Line 19: from betterAsyncore import Dispatcher, Reactor Line 20: from ssl import SSLSocket Line 21: > Why are you not using SSLSocket implemented in sslutils? SSLSocket in sslutils is based on m2c and this patch replaces m2c with standard ssl module. Line 22: _STATE_LEN = "Waiting for message length" Line 23: _STATE_MSG = "Waiting for message" Line 24: Line 25: -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
