Yeela Kaplan has posted comments on this change.

Change subject: ssl: m2crypto removal
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/39990/9/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 17: import stomp
Line 18: 
Line 19: from betterAsyncore import Dispatcher, Reactor
Line 20: from ssl import SSLSocket
Line 21: 
> SSLSocket in sslutils is based on m2c and this patch replaces m2c with stan
But as far as I can see you are not removing SSLSocket from sslutils in this 
patch...?
Line 22: _STATE_LEN = "Waiting for message length"
Line 23: _STATE_MSG = "Waiting for message"
Line 24: 
Line 25: 


-- 
To view, visit https://gerrit.ovirt.org/39990
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Dima Kuznetsov <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Ido Barkan <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to