Dima Kuznetsov has posted comments on this change. Change subject: Removing support in sysv and upstart ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/40726/4/vdsm.spec.in File vdsm.spec.in: Line 798 Line 799 Line 800 Line 801 Line 802 wrong block taken https://gerrit.ovirt.org/#/c/40726/4/vdsm/clientIF.py File vdsm/clientIF.py: Line 503: "stdio.dump", "recovery"]: Line 504: if vmId in self.vmContainer: Line 505: continue Line 506: else: Line 507: continue any chance we can make this conditional nicer? it is really confusing.. I am thinking something among the lines of: if fileType not in EXTS: continue if vmId in self.vmContainer: continue Line 508: self.log.debug("removing old file " + f) Line 509: utils.rmFile(constants.P_VDSM_RUN + f) Line 510: except: Line 511: pass -- To view, visit https://gerrit.ovirt.org/40726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9af14b3d78badc5250042508d25f294dc514a2d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
