Yeela Kaplan has posted comments on this change. Change subject: Removing support in sysv and upstart ......................................................................
Patch Set 4: Code-Review-1 (3 comments) What about: vdsmd_init_common.sh If you look inside: _has_systemd() task_load_needed_modules() Do we still need those? https://gerrit.ovirt.org/#/c/40726/4//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-06-04 16:39:42 +0300 Line 6: Line 7: Removing support in sysv and upstart Line 8: Line 9: sysvinit scripts used to support rhel >=6.6. upstart scripts used to It says bigger than... Don't you mean the smaller ones? Line 10: support debian. Both not required in later versions. systemd scripts Line 11: become the standard in fedora rhel and debian. Line 12: Line 13: Change-Id: Ib9af14b3d78badc5250042508d25f294dc514a2d https://gerrit.ovirt.org/#/c/40726/4/debian/control File debian/control: Line 114: sed (>= 4.2.1), Line 115: selinux-policy-default (>= 2.20110726), Line 116: sosreport, Line 117: sudo (>= 1.7.3), Line 118: sysv-rc, Are you sure sysv-rc is still needed? I see that its source package is sysvinit... Line 119: tree, Line 120: vdsm-python (= ${source:Version}), Line 121: xz-utils, Line 122: vdsm-python-zombiereaper (= ${source:Version}), https://gerrit.ovirt.org/#/c/40726/4/debian/dependencyMap.txt File debian/dependencyMap.txt: Line 15: glusterfs >= 3.4.0 glusterfs-common Line 16: glusterfs-fuse glusterfs-client Line 17: glusterfs-rdma glusterfs-common Line 18: glusterfs-server glusterfs-server Line 19: initscripts >= 9.42.2-1 initscripts ifupdown sysv-rc same here... Line 20: iproute iproute Line 21: iscsi-initiator-utils >= 6.2.0.872-15 open-iscsi Line 22: kernel >= 3.6 linux-image-generic Line 23: libguestfs-tools libguestfs-tools -- To view, visit https://gerrit.ovirt.org/40726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9af14b3d78badc5250042508d25f294dc514a2d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
