Yeela Kaplan has posted comments on this change. Change subject: stomp: subscription cleanup when connection lost ......................................................................
Patch Set 20: Code-Review-1 (1 comment) Looks good, other than a minor comment. https://gerrit.ovirt.org/#/c/39969/20/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 277: self._messageHandler((self._server, self, data)) Line 278: Line 279: def clean(self): Line 280: if hasattr(self._async_client, 'remove_subscriptions'): Line 281: self._async_client.remove_subscriptions() I feel this method is unnecessary, and is very confusing why we need both close AND clean. I'd prefer if you move the 2 cleanup lines into the close method. Line 282: Line 283: Line 284: class StompServer(object): Line 285: log = logging.getLogger("yajsonrpc.StompServer") -- To view, visit https://gerrit.ovirt.org/39969 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff05e4ff9d336dbfddf80002bad5bcd0dbac697f Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
