Piotr Kliczewski has posted comments on this change. Change subject: stomp: subscription cleanup when connection lost ......................................................................
Patch Set 20: (1 comment) https://gerrit.ovirt.org/#/c/39969/20/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 277: self._messageHandler((self._server, self, data)) Line 278: Line 279: def clean(self): Line 280: if hasattr(self._async_client, 'remove_subscriptions'): Line 281: self._async_client.remove_subscriptions() > I think the code will be more clear if we inline clean into close. Another the code is inlined in new patch set. Line 282: Line 283: Line 284: class StompServer(object): Line 285: log = logging.getLogger("yajsonrpc.StompServer") -- To view, visit https://gerrit.ovirt.org/39969 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff05e4ff9d336dbfddf80002bad5bcd0dbac697f Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
