Adam Litke has posted comments on this change. Change subject: StorageDomainManifest: introduce class heirarchy ......................................................................
Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/41993/2/vdsm/storage/fileSD.py File vdsm/storage/fileSD.py: Line 156 Line 157 Line 158 Line 159 Line 160 > Why did you remove this? I'll add a comment to indicate why we may not want validation in the Manifest but only in the Domain itself. Line 146: Line 147: Line 148: class FileStorageDomainManifest(sd.StorageDomainManifest): Line 149: def __init__(self, domainPath): Line 150: sdUUID = os.path.basename(domainPath) > Why did you move this here? we use it only on line 158? I will move this down in the function. Line 151: Line 152: # Using glob might look like the simplest thing to do but it isn't Line 153: # If one of the mounts is stuck it'll cause the entire glob to fail Line 154: # and you wouldn't be able to access any domain Line 169: return stats['seconds'] Line 170: Line 171: Line 172: class FileStorageDomain(sd.StorageDomain): Line 173: ManifestClass = FileStorageDomainManifest > It is common to use mixedCase for class attributes, and not CammelCase. ok, i'll reaname it. Line 174: Line 175: def __init__(self, domainPath): Line 176: manifest = self.ManifestClass(domainPath) Line 177: validateFileSystemFeatures(manifest.sdUUID, manifest.mountpoint) -- To view, visit https://gerrit.ovirt.org/41993 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia275424a8d423722efb229a4d8545f035fe5fa51 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
