Adam Litke has posted comments on this change. Change subject: StorageDomainManifest: introduce class heirarchy ......................................................................
Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/41993/2/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 409: return stats['seconds'] Line 410: Line 411: Line 412: class BlockStorageDomain(sd.StorageDomain): Line 413: ManifestClass = BlockStorageDomainManifest > manifestClass ? Done Line 414: Line 415: def __init__(self, sdUUID): Line 416: manifest = self.ManifestClass(sdUUID) Line 417: sd.StorageDomain.__init__(self, manifest) https://gerrit.ovirt.org/#/c/41993/2/vdsm/storage/fileSD.py File vdsm/storage/fileSD.py: Line 156 Line 157 Line 158 Line 159 Line 160 > I'll add a comment to indicate why we may not want validation in the Manife Actually, I decided to move it into the Manifest after all. https://gerrit.ovirt.org/#/c/41993/2/vdsm/storage/sd.py File vdsm/storage/sd.py: Line 338: def domaindir(self): Line 339: return self._manifest.domaindir Line 340: Line 341: @property Line 342: def _metadata(self): > A TODO: comment about removing this property when we are done would be nice Done Line 343: return self._manifest._metadata Line 344: Line 345: @property Line 346: def mountpoint(self): -- To view, visit https://gerrit.ovirt.org/41993 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia275424a8d423722efb229a4d8545f035fe5fa51 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
