Nir Soffer has posted comments on this change. Change subject: gluster: Allow gluster mount with additional servers ......................................................................
Patch Set 15: (3 comments) https://gerrit.ovirt.org/#/c/40665/15/tests/storageServerTests.py File tests/storageServerTests.py: Line 72: self.assertEquals(mount_con._mount.fs_file, Line 73: "/tmp/glusterSD/server:_volume") Line 74: Line 75: @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm()) Line 76: def testGlusterMountOptions(self): Use lower_case names Line 77: def glusterVolumeInfo(volname=None, volfileServer=None): Line 78: self.assertEqual(volname, "music") Line 79: self.assertEqual(volfileServer, "192.168.122.1") Line 80: return {'music': {'brickCount': '3', Line 114: gluster = GlusterFSConnection(spec="192.168.122.1:/music") Line 115: self.assertEquals(gluster.options, Line 116: "backup-volfile-servers=192.168.122.2:192.168.122.3") Line 117: Line 118: def testUserProvidedGlusterMountOptions(self): Use lower_case names Line 119: user_options = "backup-volfile-servers=server1:server2" Line 120: gluster = GlusterFSConnection(spec="192.168.122.1:/music", Line 121: options=user_options) https://gerrit.ovirt.org/#/c/40665/15/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 280: mountClass=mount.Mount): Line 281: super(GlusterFSConnection, self).__init__(spec, Line 282: vfsType, Line 283: options, Line 284: mountClass) Call kwargs properly: vfsType=vfsType, options=options, mountClass=mountClass Line 285: self._gluster_options = None Line 286: Line 287: @property Line 288: def options(self): -- To view, visit https://gerrit.ovirt.org/40665 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2478a5edc1fc9d24eb96d64a32a98a2467ce2989 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
