Sahina Bose has posted comments on this change. Change subject: gluster: Allow gluster mount with additional servers ......................................................................
Patch Set 16: (1 comment) https://gerrit.ovirt.org/#/c/40665/16/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 300: volInfo = supervdsm.getProxy().glusterVolumeInfo(volname, Line 301: volfileServer) Line 302: servers = [brick.split(":")[0] Line 303: for brick in volInfo[volname]['bricks']] Line 304: servers.remove(volfileServer) servers would be empty for a replica 1 volume. Also, for a distributed replica, the servers list would have duplicates? Line 305: return "backup-volfile-servers=" + ":".join(servers) Line 306: Line 307: Line 308: class NFSConnection(object): -- To view, visit https://gerrit.ovirt.org/40665 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2478a5edc1fc9d24eb96d64a32a98a2467ce2989 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches