Nir Soffer has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 ......................................................................
Patch Set 13: (4 comments) Please add configuration so developers can use replica 1. Check the mail thread about it. https://gerrit.ovirt.org/#/c/41931/13/tests/storageServerTests.py File tests/storageServerTests.py: Line 97: 'name': Line 98: '192.168.122.3:/tmp/music', Line 99: 'hostUuid': Line 100: '04eb591b-2fd3-489e-a22c-5d342a3c713d' Line 101: }], Separate whitespace changes to another patch Line 102: 'options': {'auth.allow': '*'}, Line 103: 'replicaCount': '3', Line 104: 'stripeCount': '1', Line 105: 'disperseCount': '0', https://gerrit.ovirt.org/#/c/41931/13/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 238: Line 239: def validate(self): Line 240: """ Line 241: This method is overriden by derived classes to perform validation. Line 242: """ This method *may* be overriden... Line 243: Line 244: def isConnected(self): Line 245: return self._mount.isMounted() Line 246: Line 288: super(GlusterFSConnection, self).__init__(spec, Line 289: vfsType, Line 290: options, Line 291: mountClass) Line 292: self._volfileServer, self._volname = self._remotePath.split(":", 1) No point to initialize stuff if you continue to clean it up. Use temporary variables and when the values are clean, initialize the object instance variables. Line 293: self._volname = self._volname.strip('/') Line 294: self._gluster_options = None Line 295: self._volinfo = None Line 296: Line 307: return self._volinfo Line 308: Line 309: def validate(self): Line 310: replicaCount = self.volinfo[self._volname]['replicaCount'] Line 311: if not replicaCount == '3': if replicaCount != 3 Line 312: raise se.UnsupportedGlusterVolumeReplicaCountError(replicaCount) Line 313: Line 314: def _get_gluster_mount_options(self): Line 315: if "backup-volfile-servers" in self._options: -- To view, visit https://gerrit.ovirt.org/41931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
