Ala Hino has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 ......................................................................
Patch Set 16: (3 comments) https://gerrit.ovirt.org/#/c/41931/16/tests/storageServerTests.py File tests/storageServerTests.py: Line 108: @permutations([['1', False], ['2', False], ['3', True], ['4', False]]) Line 109: def test_allowed_gluster_replica_count(self, replica_count, supported): Line 110: Line 111: def glusterVolumeInfo(volumeName=None, remoteServer=None): Line 112: return {'music': {'replicaCount': replica_count}} > Please fix the indentation. Done Line 113: Line 114: storageServer.supervdsm.glusterVolumeInfo = glusterVolumeInfo Line 115: Line 116: gluster = GlusterFSConnection(spec="192.168.122.1:/music") Line 117: if not supported: Line 118: self.assertRaises(se.UnsupportedGlusterVolumeReplicaCountError, Line 119: gluster.validate) Line 120: else: Line 121: self.assertIsNone(gluster.validate()) > No need to assert, just call it. The test succeeds if validate() does not r Done https://gerrit.ovirt.org/#/c/41931/16/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 280: CGROUP = "vdsm-glusterfs" Line 281: DIR = "glusterSD" Line 282: ALLOWED_REPLICA_COUNTS = [c for c in Line 283: config.get("gluster", Line 284: "allowed_replica_count").split(",")] > If we treat the possible values as strings, we can simplify: Done Line 285: Line 286: def __init__(self, Line 287: spec, Line 288: vfsType=None, -- To view, visit https://gerrit.ovirt.org/41931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
